Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): configuration changes and fixes needed to scale-test #1085

Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix(test): configuration changes and fixes needed to scale-test #1085

merged 4 commits into from
Jan 20, 2025

Conversation

alexcastilio
Copy link
Contributor

@alexcastilio alexcastilio commented Nov 29, 2024 •
edited
Loading

Description

Changes:

  • move env var name OUTPUT_FILEPATH to common/common.go
  • adjust timeout for diferent steps
  • enable operator in retina legacy helm chart installation
  • add retries to kube api requests to make it more robust to eventual failures in responses
  • add podStatus to metrics exported
  • add retina operator to get metrics from
  • other small fixes and improvements

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@alexcastilio alexcastilio requested a review from a team as a code owner November 29, 2024 16:02
@github-actions GitHub Actions
Copy link

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label Dec 30, 2024
@alexcastilio alexcastilio removed the meta/waiting-for-author Blocked and waiting on the author label Jan 2, 2025
@alexcastilio alexcastilio force-pushed the alexcastilio/fix-scale-test branch from 9791c43 to 419dc4d Compare January 2, 2025 16:16
matmerr
matmerr previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@matmerr matmerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like linter has some feedback though

@alexcastilio alexcastilio force-pushed the alexcastilio/fix-scale-test branch from 419dc4d to c2ef8e9 Compare January 7, 2025 08:54
@alexcastilio alexcastilio force-pushed the alexcastilio/fix-scale-test branch 8 times, most recently from bf79ef1 to c57c17a Compare January 7, 2025 15:50
timraymond
timraymond requested changes Jan 7, 2025
View reviewed changes
test/e2e/framework/kubernetes/delete-namespace.go Outdated Show resolved Hide resolved
test/e2e/framework/kubernetes/delete-namespace.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/add-shared-labels.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/add-unique-labels.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/create-resources.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/get-publish-metrics.go Show resolved Hide resolved
test/e2e/framework/scaletest/get-publish-metrics.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/get-publish-metrics.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/get-publish-metrics.go Outdated Show resolved Hide resolved
test/e2e/framework/scaletest/add-shared-labels.go Outdated Show resolved Hide resolved
@alexcastilio alexcastilio force-pushed the alexcastilio/fix-scale-test branch 4 times, most recently from bb3a29f to bcb2d2d Compare January 8, 2025 17:38
@alexcastilio alexcastilio force-pushed the alexcastilio/fix-scale-test branch 4 times, most recently from 03fabe3 to babf593 Compare January 15, 2025 17:12
@alexcastilio alexcastilio force-pushed the alexcastilio/fix-scale-test branch from babf593 to afe6beb Compare January 15, 2025 19:01
matmerr
matmerr previously approved these changes Jan 16, 2025
View reviewed changes
apontejaj
apontejaj previously approved these changes Jan 16, 2025
View reviewed changes
timraymond
timraymond previously approved these changes Jan 17, 2025
View reviewed changes
@alexcastilio alexcastilio added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@alexcastilio alexcastilio added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@alexcastilio
fix loop typo
2dc3dbb 
Signed-off-by: Alex Castilio dos Santos <[email protected]>
@alexcastilio alexcastilio dismissed stale reviews from timraymond, apontejaj, and matmerr via 2dc3dbb January 20, 2025 09:56
@alexcastilio alexcastilio added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit b3cd0ec Jan 20, 2025
27 checks passed
@alexcastilio alexcastilio deleted the alexcastilio/fix-scale-test branch January 20, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SRodi SRodi SRodi approved these changes

@apontejaj apontejaj apontejaj left review comments

@matmerr matmerr matmerr left review comments

@timraymond timraymond timraymond left review comments

@rbtr rbtr Awaiting requested review from rbtr rbtr is a code owner automatically assigned from microsoft/retina

@jpayne3506 jpayne3506 Awaiting requested review from jpayne3506 jpayne3506 is a code owner automatically assigned from microsoft/retina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcastilio @timraymond @rbtr @matmerr @apontejaj @SRodi